search

ueokande / vim-vixen

Accelerates your web browsing with Vim power!!
https://ueokande.github.io/vim-vixen/
MIT License
2.11k stars 137 forks source link

Blacklist no longer seems to work #718

Open Vinnl opened 4 years ago

Vinnl commented 4 years ago

I'm opening this issue because:

Description

I just got version 0.27, and now it seems that the blacklist no longer works.

Failure Information (for bugs)

I have a number of sites blacklisted because I want to use their native shortcuts, but Vim Vixen seems to override them now.

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

  1. Add a site to the Vim Vixen blacklist, e.g. mail.google.com.
  2. Visit that website, then try to use one of its keyboard shortcuts that conflicts with a Vim Vixen one. In my case, I tried j and k to switch between emails in Gmail (and to switch between stories on feedly.com).
  3. Observe that Vim Vixen's behaviour is executed, rather than the website's. (In this case, the page scrolled up/down, rather than switching emails or stories.)

System configuration

Console logs

Any relevant log in developer tools:

N/A

Vinnl commented 4 years ago

Reading through the changes between 0.26 and 0.27, I saw the addition of CachedSettingsRepository - which prompted me to try restarting my browser. Alas, that fixed it.

So I guess the specific thing that goes wrong here is that settings are not properly initialised after upgrading to the version with Sync support, until the browser is restarted.