search

ueokande / vim-vixen

Accelerates your web browsing with Vim power!!
https://ueokande.github.io/vim-vixen/
MIT License
2.11k stars 137 forks source link

Blacklisting does not work #719

Open Math3mat1x opened 4 years ago

Math3mat1x commented 4 years ago

I'm opening this issue because:

Description

Even after blacklisting https://duckduckgo.com/, I still have Vim Vixen extension enabled. I can use Shift + Esc to disable it, but it is not permanent. I have seen a similar Issue saying you have to restart the browser in order for the settings to apply, but it doesn't work for me.

Steps to Reproduce

  1. Add "blacklist": [ "https://duckduckgo.com/" ] to the JSON
  2. Go to https://duckduckgo.com/
  3. The Vim-like shortcuts provided by DuckDuckGo does not work anymore. To make them work again, press Shift + Esc

System configuration

jduan commented 4 years ago

I'm having the same problem with gmail. Here's how I blacklist:

  "blacklist": [
    "mail.google.com"
  ]

It stopped working recently (presumably after upgraded to 0.27)

Thanks for all the hard work. It's an essential plugin for me!

ueokande commented 4 years ago

Umm... I cannot reproduce it. Restarting your browser might fix the issue (see https://github.com/ueokande/vim-vixen/issues/718#issuecomment-590107916). Please try it.

jduan commented 4 years ago

I confirm that restarting the browser fixed the problem for me. And I'm on Mac OS.

Math3mat1x commented 4 years ago

This method doesn't work for me, here's my full JSON: { "keymaps": { "0": { "type": "scroll.home" }, ":": { "type": "command.show" }, "o": { "type": "command.show.open", "alter": false }, "O": { "type": "command.show.open", "alter": true }, "t": { "type": "command.show.tabopen", "alter": false }, "T": { "type": "command.show.tabopen", "alter": true }, "w": { "type": "command.show.winopen", "alter": false }, "W": { "type": "command.show.winopen", "alter": true }, "b": { "type": "command.show.buffer" }, "a": { "type": "command.show.addbookmark", "alter": true }, "k": { "type": "scroll.vertically", "count": -1 }, "j": { "type": "scroll.vertically", "count": 1 }, "h": { "type": "scroll.horizonally", "count": -1 }, "l": { "type": "scroll.horizonally", "count": 1 }, "<C-U>": { "type": "scroll.pages", "count": -0.5 }, "<C-D>": { "type": "scroll.pages", "count": 0.5 }, "<C-B>": { "type": "scroll.pages", "count": -1 }, "<C-F>": { "type": "scroll.pages", "count": 1 }, "gg": { "type": "scroll.top" }, "G": { "type": "scroll.bottom" }, "$": { "type": "scroll.end" }, "d": { "type": "tabs.close", "select": "right" }, "D": { "type": "tabs.close", "select": "left" }, "x$": { "type": "tabs.close.right" }, "!d": { "type": "tabs.close.force" }, "u": { "type": "tabs.reopen" }, "gT": { "type": "tabs.prev" }, "gt": { "type": "tabs.next" }, "g0": { "type": "tabs.first" }, "g$": { "type": "tabs.last" }, "<C-6>": { "type": "tabs.prevsel" }, "r": { "type": "tabs.reload", "cache": false }, "R": { "type": "tabs.reload", "cache": true }, "zp": { "type": "tabs.pin.toggle" }, "zd": { "type": "tabs.duplicate" }, "zi": { "type": "zoom.in" }, "zo": { "type": "zoom.out" }, "zz": { "type": "zoom.neutral" }, "f": { "type": "follow.start", "newTab": false, "background": true }, "F": { "type": "follow.start", "newTab": true, "background": false }, "m": { "type": "mark.set.prefix" }, "'": { "type": "mark.jump.prefix" }, "H": { "type": "navigate.history.prev" }, "L": { "type": "navigate.history.next" }, "[[": { "type": "navigate.link.prev" }, "]]": { "type": "navigate.link.next" }, "gu": { "type": "navigate.parent" }, "gU": { "type": "navigate.root" }, "gi": { "type": "focus.input" }, "gf": { "type": "page.source" }, "gh": { "type": "page.home", "newTab": false }, "gH": { "type": "page.home", "newTab": true }, "y": { "type": "urls.yank" }, "p": { "type": "urls.paste", "newTab": false }, "P": { "type": "urls.paste", "newTab": true }, "/": { "type": "find.start" }, "n": { "type": "find.next" }, "N": { "type": "find.prev" }, ".": { "type": "repeat.last" }, "<S-Esc>": { "type": "addon.toggle.enabled" } }, "search": { "default": "duckduckgo", "engines": { "google": "https://google.com/search?q={}", "yahoo": "https://search.yahoo.com/search?p={}", "bing": "https://www.bing.com/search?q={}", "duckduckgo": "https://duckduckgo.com/?q={}", "twitter": "https://twitter.com/search?q={}", "wikipedia": "https://en.wikipedia.org/w/index.php?search={}" } }, "properties": { "hintchars": "abcdefghijklmnopqrstuvwxyz", "smoothscroll": false, "complete": "sbh" }, "blacklist": [ "https://duckduckgo.com/" ] } I even deleted my old profile and tried from a vanilla Firefox, this doesn't fix the issue. Vim-Vixen 0.27 is not blacklisting on Firefox 73.0 (Ubuntu 19.10).

Math3mat1x commented 4 years ago

Another guy have this issue (https://addons.mozilla.org/fr/firefox/addon/vim-vixen/reviews/): image

jduan commented 4 years ago

Forgot to mention that I'm on Mac and restart fixed the problem. I'm using latest Firefox 73.0.1

hnnazm commented 4 years ago

I have the same problem and already try restart. I'm on Mac , Firefox 74.0

rvolosatovs commented 4 years ago

Firefox 75.0 on Linux, I was struggling with this as well, however it seems like the solution is not to include the protocol and just type the FQDN, so:

chunga2020 commented 4 years ago

Firefox 75.0, Ubuntu 20.04. Also having this problem. You can find my config JSON here. Smooth scrolling and hint chars work as expected, but not blacklisting. Tried restarting my browser, to no avail. Also tried @rvolosatovs's solution of excluding the protocol. That didn't work either. Using Shift-Esc to turn off the plugin altogether does work, though I'd like it if I didn't have to resort to that.

nullobject commented 4 years ago

Firefox 75.0 on Linux, I was struggling with this as well, however it seems like the solution is not to include the protocol and just type the FQDN, so:

This worked for me in Firefox 76, Ubuntu 20.04.

chunga2020 commented 4 years ago

@nullobject Ah, confirmed. I was neglecting the www part of the FQDN

hanzhaogang commented 3 years ago

I have the smae issue for mail.qq.com. WIndows 10+ firefox 83.0

demiaus commented 3 years ago

I have the same issue, Ubuntu 18.04, FF 84.0.2. Tried with and without protocol, with and without 'www', and restarting browser.

PolyMMA commented 3 years ago

I had similar issues. For me it turned out that I had to remove the https:// and more importantly end with a * to clarify that I want the blacklist entry to be valid for the whole domain.

For Gmail I use: "blacklist": ["mail.google.com/*"]

This requires at least a reload of the page. You can verify that the changes in the JSON are implemented by testing to switch some function. For example toggle smooth scrolling to verify its functionality "smoothscroll": true,.

sevillaarvin commented 3 years ago

It didn't work for me before, but it works now:

"blacklist": [
    "mail.google.com"
  ]
$ lsb_release  -a
LSB Version:    n/a
Distributor ID: ManjaroLinux
Description:    Manjaro Linux
Release:        20.2.1
Codename:       Nibia
$ firefox --version
Mozilla Firefox 85.0.2