search

uepg / laravel-sybase

Connection and Laravel Eloquent driver for Sybase
GNU General Public License v2.0
33 stars 18 forks source link

Refactor function `compileNewQuery` of SybaseConnection class #22

Open nunomazer opened 8 years ago

nunomazer commented 8 years ago

Should use collections

tzkmx commented 8 years ago

Do you have any tests for this class in order to being able to do the refactor without any functionality loss? At least some characterization tests?

mainginski commented 8 years ago

Formally not, but if you want I can list all the features of this class.

tzkmx commented 8 years ago

It would be very usefull, I'd lke a lot to contribute to this refactoring. Thanks in advance.

mainginski commented 8 years ago

Ok, I can make this on Tuesday!

mainginski commented 8 years ago

Hello, as promised: https://github.com/uepg/laravel-sybase/wiki/For-contributors