search

uesteibar / neuron

A GraphQL client for Elixir
https://hex.pm/packages/neuron
Other
331 stars 35 forks source link

Add Testing modules and info to README about it #46

Closed esse closed 5 years ago

esse commented 5 years ago

This PR adds a mechanism to write tests checking Neuron queries and validating it against provided lambdas.

We have been using it for quite some time in our internal projects and extracted it to the upstream in this PR.

uesteibar commented 5 years ago

Hey @esse! Thanks for taking the time to put this together 😃

However, I'm not entirely sure if this feature should be part of the library. When mocking this kind of modules I'm more inclined to using something like mox to provide a mocked version of it via configuration (you can see an example in the docs), and afaik that's the most extended and recommended way of doing it in elixir.

I would rather keep this library as simple as possible, and as this can be implemented outside of this codebase just fine I'd prefer to do that. Do you think this could be made into its own library? That way other people could still use it :)

Thanks again for sharing this ❤️ I'll close this PR although we can still continue discussing this further here 😃