search

uesteibar / neuron

A GraphQL client for Elixir
https://hex.pm/packages/neuron
Other
331 stars 35 forks source link

Fix/dialyzer syntax #51

Closed hez closed 5 years ago

hez commented 5 years ago

Fixes a couple broken specs and adds the HTTPoison.Error.t() to the Neuron.query/3 return def.

Also added dialyxir dependency for nicer dialyzer errors.

fixes: https://github.com/uesteibar/neuron/issues/50

uesteibar commented 5 years ago

Hey thanks for taking care of it yourself @hez! ❤️

Do you think we could add another step to the travis build to run dialyxir? It seems to be straightforward (explained here for travis) and it would be a great improvement.

If you could make all this PR into two commits that follow the contributing guidelines, one for fixing the type annotation and another one for adding dialyxir and fixing the types, that would be awesome too 🦄

hez commented 5 years ago

@uesteibar totally! We do it with Travis on our projects, the most important part is to get it caching the plts (or you'll drag their servers to halt). If I get a couple I'll add it to a new ~this~ PR.

hez commented 5 years ago

@uesteibar I pushed up this commit in another branch https://github.com/uesteibar/neuron/commit/8a557a72d9d1af71a215dfb3ee25bf1bef99c3d5 but was lazy and didn't want to deal with the conflict/resolution in mix.* so its built on this branch. I will create a PR once this has been merged.

uesteibar commented 5 years ago

Great job, thank you! ❤️ 🎉

I will create a PR once this has been merged

that sounds great, please go ahead!