Unable to translate on the github website when opening an external link

uetchy / Polyglot

🌏 The missing Safari extension that translates selected text into your native language.

Other

482 stars 44 forks source link

Unable to translate on the github website when opening an external link #104

Open Oleg-Chashko opened 3 years ago

Oleg-Chashko commented 3 years ago

Under certain conditions, it hangs while waiting for the translation of the text. This happens when the link is opened from the desktop. It seems that this behavior appeared after the last update of the application.

Safari v.14.1 (16611.1.21.161.6)
Polyglot v.3.4

Example

https://user-images.githubusercontent.com/62497891/117031536-f52e7580-ad00-11eb-938e-ba146fe5b90c.mp4

Example Link (https://github.com/AdguardTeam/AdguardBrowserExtension/issues/1799#issuecomment-831965307) Example ZIP view it on GitHub.zip

gingerbeardman commented 3 years ago

This looks like API limit has been reached. Google Translate only lets you translate a certain number of times over a period of time.

Wait and try again later? See #55

Oleg-Chashko commented 3 years ago

This looks like API limit has been reached. Google Translate only lets you translate a certain number of times over a period of time.

Wait and try again later? See #55

Unfortunately not, I think there is another problem here.

As an example, not one translation has been made today. The link is open from Apple-mail, the first translation for today immediately causes a problem. And if you translate into a direct site, there is no problem. To read, I very rarely use the application. So I do not exceed the limit. And as I wrote above that I did not have this problem before. P.S. the latest update hasn't benefited the app.

Example

https://user-images.githubusercontent.com/62497891/117108819-08cef000-ad84-11eb-9596-0c655088fb9b.mp4

gingerbeardman commented 3 years ago

Do you see any errors in web inspector console?

Oleg-Chashko commented 3 years ago

Do you see any errors in web inspector console?

https://user-images.githubusercontent.com/62497891/117142553-2154ff80-adb0-11eb-9ca0-aa9f61d6c92e.mp4

Oleg-Chashko commented 3 years ago

Found what this problem is related to. When you run the link. The window in which you want to translate is highlighted in blue. There will be no translation! If you click on a page of the website, the translation will be done. This is due to the structure of this website. This problem was not found on other Internet sites.

Example

https://user-images.githubusercontent.com/62497891/117150002-0be3d380-adb8-11eb-9602-4e97e0078026.mp4

gingerbeardman commented 3 years ago

Good find! Please edit/change the bug report accordingly.

Oleg-Chashko commented 3 years ago

Good find! Please edit/change the bug report accordingly.

Always happy to help!