search

uetchy / Polyglot

🌏 The missing Safari extension that translates selected text into your native language.
Other
482 stars 44 forks source link

Translation fails when text contains link #109

Open gingerbeardman opened 3 years ago

gingerbeardman commented 3 years ago

Describe the bug Translation fails when text contains link

To Reproduce Steps to reproduce the behavior:

  1. Go to https://github.com/uetchy/Polyglot/blob/master/README.md
  2. Select first item of Setup list

Expected behavior

Actual behavior

Screenshots

Screen shot 2021-05-24 at 13 29 24

Version (please complete the following information):

Oleg-Chashko commented 3 years ago

Hi, @gingerbeardman Matt, i don't see any translation problems here. Maybe it's because I have a different version of Safari?

Screen_1

Oleg-Chashko commented 3 years ago

Matt, sometimes I've noticed that Apple can update the browser "out of sight", but not update the MacOS system. Like an emergency security update or internal Safari settings, without warning the user. Because of this, I write the full version number of the example: Safari v.14.1 (16611.1.21.161.6)

gingerbeardman commented 3 years ago

Have edited my app versions above.

Also, here's a screen recording: https://imgur.com/a/1bazwLB

Only difference is that I use instant translate, rather than the Polyglot button.

Oleg-Chashko commented 3 years ago

Have edited my app versions above.

Also, here's a screen recording: https://imgur.com/a/1bazwLB

Only difference is that I use instant translate, rather than the Polyglot button.

And here, instant transfer, no button.

Screen Shot 2021-05-24 at 16 06 25

Screen_2

gingerbeardman commented 3 years ago

The worst type of bug, one that's difficult to reproduce!

Oleg-Chashko commented 3 years ago

The worst type of bug, one that's difficult to reproduce!

Completely agree with you, if you're not hard to put (Auto detect) and (Russian) language and see if the result. Maybe it depends on what language you translate to?

Screen Shot 2021-05-24 at 17 25 08
Oleg-Chashko commented 3 years ago

You are translating from English into English. If I translate from Russian into Russian there will be a problem as you have. Where this app takes the words, the word is not there. I think that's the secret of this phenomenon. Example: Screen_3

gingerbeardman commented 3 years ago

Yes! Good catch.

Oleg-Chashko commented 3 years ago

Yes! Good catch.

He who seeks, he will always find. The main thing is to never give up. :) It was my pleasure to help you.