search

uetchy / Polyglot

🌏 The missing Safari extension that translates selected text into your native language.
Other
482 stars 44 forks source link

Polyglot 3 #30

Closed uetchy closed 5 years ago

uetchy commented 6 years ago

Mac App Store version of Polyglot.

Current status

Shipped.

Remaining Tasks

Future work

uetchy commented 6 years ago

The document for migrating from legacy extensions: https://developer.apple.com/documentation/safariservices/safari_app_extensions/converting_a_legacy_safari_extension_to_a_safari_app_extension

Safari Extension development guide: https://developer.apple.com/documentation/safariservices/safari_app_extensions/building_a_safari_app_extension

uetchy commented 5 years ago

Sadly, I have been away and don't have a chunk of time enough. If someone is willing to contribute into Swift & Safari App Extension impl., it would be much appreciated! ☺️

The current code base is placed on mas branch.

gingerbeardman commented 5 years ago

I think it's fairly low priority until Safari Extension gallery source is retired (WWDC/June? Public/October?

uetchy commented 5 years ago

Finally. About to ship this month.

Screen Shot 2019-07-07 at 3 36 23
uetchy commented 5 years ago
Screen Shot 2019-07-07 at 4 52 04 Screen Shot 2019-07-07 at 4 52 38

Upcoming dark/light mode and vibrancy support.

uetchy commented 5 years ago

Pre-release version is out! Leave a comment if you find a glitch.

gingerbeardman commented 5 years ago

Great work!

A few issues...

  1. I am seeing bad encoding on translated result when set to Auto Detect:

http://www.katch.ne.jp/~guts-2t86/game6.html Screen shot 2019-07-07 at 11 13 56

http://sekaiyugi.com/games/hanafuda-1.html Screen shot 2019-07-07 at 11 14 56

If I set Source Language to Japanese, display works OK: Screen shot 2019-07-07 at 11 18 00

  1. BUT... translated text seems incorrect? seems to be coming from a source that is not the selected text or current window?

Compare Polyglot 2.6.0 Screen shot 2019-07-07 at 11 19 26

gingerbeardman commented 5 years ago
  1. there is no way to bring Polyglot.app window back if it is closed using red dot. This will result in failed MAS submission in my experience with other Safari App Extensions.

Recommended solution: quit app on window close.

uetchy commented 5 years ago

@gingerbeardman Thank you for the super fast review! Just fixed the Unicode related issue and updated pre-release tag. It should work now.

uetchy commented 5 years ago

Recommended solution: quit app on window close.

Added to ToDo

gingerbeardman commented 5 years ago

Good Job!

Screen shot 2019-07-07 at 16 30 37

gingerbeardman commented 5 years ago

Added to ToDo

AppDelegate.swift:

func applicationShouldTerminateAfterLastWindowClosed(_ sender: NSApplication) -> Bool {
    return true
}

edit: ah, you already did it!

gingerbeardman commented 5 years ago

Problem reading text over dark background. Screen shot 2019-07-07 at 20 31 34

Workaround is to select translated text Screen shot 2019-07-07 at 20 31 29

uetchy commented 5 years ago

@gingerbeardman put more opacity on the panel. try the latest build and see if the issue is fixed.

uetchy commented 5 years ago
Screen Shot 2019-07-08 at 16 37 27 Screen Shot 2019-07-08 at 16 37 45

The latest build contains "synonyms" feature that displays related words during single word lookups.

gingerbeardman commented 5 years ago

Even better than ever!

gingerbeardman commented 5 years ago

Possible to catch some of the outstanding issues? Such as https://github.com/uetchy/Polyglot/issues/29

gingerbeardman commented 5 years ago

Synonym feature display seems small for me?

Screen shot 2019-07-08 at 11 35 15

uetchy commented 5 years ago

I won't fix #29 in this release because there are some difficulties lying down (e.g. difficulties on precise language detection and false negatives)

uetchy commented 5 years ago

new build includes fixes on the font-size issue.

uetchy commented 5 years ago

Polyglot 3 is now available at Mac App Store and mas branch has been merged into master 🚀 Huge thanks to all the contributors involved in this issue and Polyglot.