search

uetchy / Polyglot

🌏 The missing Safari extension that translates selected text into your native language.
Other
483 stars 44 forks source link

[REQ] Button to hide popup without deselecting text #72

Open gingerbeardman opened 4 years ago

gingerbeardman commented 4 years ago

Is your feature request related to a problem? Please describe. Polyglot translates all selected text, no mater what language, so it become difficult to select text for the purposes of copy and paste or quoting using web app forum popup.

Describe the solution you'd like I'd like a button to hide popup without deselecting text

Describe alternatives you've considered I have to select far more than the text I want as a workaround, see #70 (Maybe a 'copy' button)

Additional context Also see #29 (only translate "foreign" text)

uetchy commented 4 years ago

not sure of the situation you are facing. You can copy the text in the Polyglot panel. If it's about instant mode, I think it's faster to turn off instant mode or consider adding a toolbar button to switch instant translation feature. Furthermore, I think we can change the behavior in instant mode to cope with this issue.

gingerbeardman commented 4 years ago

The polyglot panel hides things that I need to click.

uetchy commented 4 years ago

You can dismiss the panel clicking outside it. Adding a toolbar button to switch instant mode looks like a simpler solution to this. I don't use instant mode, and for such users, the hide button sounds a little too much complicated.

gingerbeardman commented 4 years ago

Clicking outside panel also closes the web-app-ui that appeared on selection.

gingerbeardman commented 4 years ago

I think Escape to close panel would be easy?

I will find time to add it myself.

uetchy commented 4 years ago

@gingerbeardman awesome! If you find any problem with the development setup, leave a comment here.