uetchy / create-create-app

⚡️ Create your own `create-something` app.
MIT License
94 stars 24 forks source link

npm publish doesn't change npm create templates #27

Closed akabekobeko closed 3 years ago

akabekobeko commented 3 years ago

I updated the templates/ with create-book using create-create-app and then npm pulish, but the one generated by running npm create book is still the old templates.

Is there anything else need to do to update the image run by npm create other than npm publish?

README.md explains that npm publish is running.

3. Publish package to npm

Run npm publish or yarn publish to publish your create-greet app to npm.

When I installed the published one with npm i create-book, npm was up to date.

uetchy commented 3 years ago

quick search resulted in this issue: https://github.com/npm/cli/issues/2395

looks like that behavior has been fixed in v7.8.0, which was published just 5 days ago. https://github.com/npm/cli/commit/37613e4e686e4891210acaabc9c23f41456eda3f

Try updating npm and see the problem persists

akabekobeko commented 3 years ago

Thank you. When I checked the version of npm in the environment where npm publish was done, it was 7.7.6.

Let's update npm and then check.

akabekobeko commented 3 years ago

I updated the version of create-book to npm publish in an environment where npm was updated to 7.8.0.

$ npm -v
7.8.0

And when I ran npm create book sample in the same environment, the old templates/default was installed. After that, when I ran the following, the published create-book was up to date.

$ cd sample
$ npm i create-book

So it doesn't seem to be fixed just by updating npm 7.8.0. Since it is a problem of npm cli, we will observe it at a fixed point.

akabekobeko commented 3 years ago

It seems to be a problem in my environment (npx cache?), So close it. Thank you for your research and comments!