search

uetchy / namae

☕️ Grab a slick name for your new project
https://namae.dev
Apache License 2.0
695 stars 36 forks source link

Russian translation #158

Closed MadProbe closed 2 years ago

MadProbe commented 2 years ago

This PR adds russian translation for this website. Translation notes:

  1. Blog article referred as "Introduction" has been translated as "Site functions description".
  2. "Getting started" has been translated as "Start" since no equivalent with same meaning exists in Russian.
  3. "About" has been translated as "About site"

Also I think search input element's placeholder could be changed to "Type a name here" as this phrase fits as a placeholder better than just "search".

uetchy commented 2 years ago

Also I think search input element's placeholder could be changed to "Type a name here" as this phrase fits as a placeholder better than just "search".

Agreed. Go ahead pushing changes to the en translation👍

MadProbe commented 2 years ago

From Vercel's preview I want to acknowledge the fact that the search input's placeholder in russian localization is too big to fit in the search box.
Is there a good way to make the placeholder more little in the code than just hard-coding the solution?

MadProbe commented 2 years ago

May I ask you to give some input on this?

uetchy commented 2 years ago

@all-contributors add @MadProbe for translation

allcontributors[bot] commented 2 years ago

@uetchy

I've put up a pull request to add @MadProbe! :tada: