search

uf-mil / mil

Monorepo of the Machine Intelligence Lab at the University of Florida
https://mil.ufl.edu/docs
Other
46 stars 29 forks source link

Migrate simulated and world camera topic names to consistent format #1281

Open cbrxyz opened 2 months ago

cbrxyz commented 2 months ago

What needs to change?

Right now, the simulated camera topics show up as:

/wamv/sensors/cameras/front/left/image_raw

The real-life camera topics show up as:

/camera/front/left/image_raw

We should migrate these topic names (and nodes who use them) to a consistent format!

How would this task be tested?

  1. Ensure that all tests pass and NaviGator doesn't break once these changes are made!
thadavale commented 1 month ago

This week, I created a branch for this topic and began looking into the topic names and the nodes that use them. I also began compiling a list of files that use the relevant topic names and researching how to migrate topic names.

thadavale commented 1 month ago

This week I updated all of the rostopic names to be consistent with each other and worked on ensuring the existing tests still worked. However, the camera info is not able to be found currently, so I will work on fixing this error next.

lynettehemingway commented 1 month ago

This week I was unable to work on as much as I would like due to the hurricane. However, I learned how to migrate topic names and plan on helping fix the camera info error.

thadavale commented 1 month ago

This week, I tried many different methods and was finally able to fix the error I previously encountered by remapping the old simulation-specific topic names onto the new real-life topic names inside simulation.launch and vrx_classifier.launch. I also made a pull request.