ufal / charles-translator-web-frontend

Charles Translator: MT from Charles University
6 stars 7 forks source link

Favorite/starred items in the history #32

Closed martinpopel closed 2 years ago

martinpopel commented 2 years ago

Each item in the history should have a star button. The button could be added also above the input (or translation?) box.

Starred items could be on top of the history list or they could be visible as suggestions below the input box (even without clicking on the history button).

EbrithilNogare commented 2 years ago

I added only stars in history menu, not in input box.

Adding new star button to input would be confusing for user, I think.

martinpopel commented 2 years ago

Thanks. It works for me, so I think it could be deployed. I have a list of possible improvements:

EbrithilNogare commented 2 years ago

Dots were added to overflowed text (still keeping its original content).

Tooltips added.

History will save everything after 3 seconds (shortened from 5seconds). Items in history were never duplicates and now it will not be even prefixes e.g. Ahoj se ulozi do historie, Ahojky prepise Ahoj, Aho vytvori novy zaznam. Takze po techto stavech Ahoj -> Ahojky -> Ahojk bude v historii [Ahojk, Ahojky] .

EbrithilNogare commented 2 years ago

there were bug, where css minifier and optimizer makes css rules inconsistent against clear dev builds css. Now it is fixed. For testing: long text will have in history triple dots at the end and will not create scroll bar (horizontal)

EbrithilNogare commented 2 years ago

closing as it is already deployed