search

ufal / clarin-dspace

clarin-dspace digital repository based on DSpace and LINDAT/CLARIN DSpace
http://lindat.cz
BSD 3-Clause "New" or "Revised" License
27 stars 17 forks source link

Missing INF icon #1024

Open TomazErjavec opened 1 year ago

TomazErjavec commented 1 year ago

We have a licence that has the Inform before use/INF restriction, and is used by several items, e.g. http://hdl.handle.net/11356/1696. Here the licence box says "This item is Academic Use and licensed under: CLARIN.SI Licence ACA ID-BY-NC-INF-NORED 1.0" and in the next line there are two icons, for "Attribution required" and "Non-commercial". However, before these two icons, there should also be the "inf.png" icon, which is missing. Depending on the browser, it either does not show at all (Firefox) or shows up as a broken icon (Chrome).

The url of the icon should be https://www.clarin.si/repository/xmlui/themes/UFAL/images/licenses/inf.png but it doesn't exist in our repository and neither at UFAL's https://lindat.mff.cuni.cz/repository/xmlui/themes/UFAL/images/licenses/inf.png. It should be in https://github.com/ufal/clarin-dspace/tree/clarin/dspace-xmlui/src/main/webapp/themes/UFAL/images/licenses but isn't there either.

I guess you never made it, and never notriced it is missing, as it seems UFAL does not have any INF licences.

kosarko commented 1 year ago

@TomazErjavec, you are probably right. Not sure why the behavior is different between browsers. I thought there was some sort of onError handler that hides broken images, but that doesn't seem to be the case (at least not globally).

Do you have any particular image in mind that we could use?

TomazErjavec commented 1 year ago

Do you have any particular image in mind that we could use?

I like the top right corner one or second in bottom row here. However, these are copyrighted, but I guess something similar could be found CC0 somewhere. What do you think of the overall idea?