search

ufal / clarin-dspace

clarin-dspace digital repository based on DSpace and LINDAT/CLARIN DSpace
http://lindat.cz
BSD 3-Clause "New" or "Revised" License
26 stars 17 forks source link

Shibboleth - 1.3.1.2. System initiated login #1076

Closed kosarko closed 4 months ago

kosarko commented 7 months ago

Expectation

When there’s no user logged in and this anonymous user tries to do an action that requires a login (accessing a restricted resource, going directly to “my submissions”, etc.), the system must ask him to log in. It should be using discojuice as well. As an example go to http://hdl.handle.net/11234/1-1664 (https://lindat.mff.cuni.cz/repository/xmlui/handle/11234/1-1664 ) and try downloading the file.

Actual behavior

  1. downloading the mentioned file not ok - I end up at 404 - https://ufal-point-dev.ufal.hide.ms.mff.cuni.cz/repository/api/repository/api/core/bitstreams/handle/11234/1-1664/pcedt2.0-coref.zip?sequence=1&isAllowed=n actually maybe https://github.com/ufal/clarin-dspace/issues/1070
  2. going to /mydspace seems to popup ~dspace~ discojuice correctly
kosarko commented 5 months ago

@milanmajchrak 1. seems ok (when testing on dspace-dev...). 2. used to work correctly but it no longer does...

https://github.com/ufal/clarin-dspace/assets/1842385/54e5217c-fb32-4e71-b7f3-d0da8be85a36

why is the toggle at https://github.com/dataquest-dev/dspace-angular/blob/b45168ebda1187fa54f10f496fb6e766437b0684/src/app/shared/log-in/methods/password/log-in-password.component.ts#L166 conditional?

kosarko commented 4 months ago

closing this one as it seems fine (except for the slow refresh mentioned in #1108)