ufal / clarin-dspace

clarin-dspace digital repository based on DSpace and LINDAT/CLARIN DSpace
http://lindat.cz
BSD 3-Clause "New" or "Revised" License
27 stars 17 forks source link

version drop down does not work on Firefox #874

Open kreetrapper opened 6 years ago

kreetrapper commented 6 years ago

The version drop down (as used for example in https://lindat.mff.cuni.cz/repository/xmlui/handle/11234/1-2837) normally gives the option to click the different versions to go directly to their submission pages. This does not work in Firefox (tested in 61.0.1). The drop down appears normally, but none of the versions is clickable.

Ansa211 commented 5 years ago

Additionally to the behaviour described above: the drop down seems to be "see through" in the sense that when the mouse hovers over the drop down in a location such that there is a clickable link below it, clicking will open the webpage linked by the item below.

dropdown

Tested with Firefox Quantum 62.0.3 (64-bit), Mozilla Firefox for Ubuntu canonical - 1.0

iiegn commented 5 years ago

At least the installation at eurac, seems to have degraded into the behaviour of #27. See, for example, http://hdl.handle.net/20.500.12124/6

The reason is that a call is made to the REST API:

but the call should actually have a filled value for undefined, like

Maybe this has been fixed together with #27 in a newer version @kreetrapper?

kosarko commented 5 years ago

@iiegn Do you mean issue 27 in our tracker or some other? Btw the issue is actually one step before when the javascript makes a request for rest/handle/20.500.12124/6 and for some reason this returns xml not json (so the id in the next step is undefined). When I ask directly for application/json (with curl) I get a 500 error.

kosarko commented 5 years ago

@iiegn What version are you running?

kreetrapper commented 5 years ago

@iiegn What version are you running?

We're running CLARIN-DSpace 2019.01.

kosarko commented 5 years ago

@kreetrapper can you run find | grep "jersey" in your installation dir? I think it should return only these (mind especially the version number):

./webapps/rest/WEB-INF/lib/jersey-client-2.27.jar
./webapps/rest/WEB-INF/lib/jersey-container-servlet-2.27.jar
./webapps/rest/WEB-INF/lib/jersey-server-2.27.jar
./webapps/rest/WEB-INF/lib/jersey-common-2.27.jar
./webapps/rest/WEB-INF/lib/jersey-container-servlet-core-2.27.jar
./webapps/rest/WEB-INF/lib/jersey-hk2-2.27.jar
./webapps/rest/WEB-INF/lib/jersey-media-moxy-2.27.jar
./webapps/rest/WEB-INF/lib/jersey-entity-filtering-2.27.jar
./webapps/rest/WEB-INF/lib/jersey-media-jaxb-2.27.jar
riccardodg commented 5 years ago

On 09/20/2019 10:42 AM, Ondřej Košarko wrote:

@kreetrapper https://github.com/kreetrapper can you run |find | grep "jersey"| in your installation dir? I think it should return only these (mind especially the version number):

|./webapps/rest/WEB-INF/lib/jersey-client-2.27.jar ./webapps/rest/WEB-INF/lib/jersey-container-servlet-2.27.jar ./webapps/rest/WEB-INF/lib/jersey-server-2.27.jar ./webapps/rest/WEB-INF/lib/jersey-common-2.27.jar ./webapps/rest/WEB-INF/lib/jersey-container-servlet-core-2.27.jar ./webapps/rest/WEB-INF/lib/jersey-hk2-2.27.jar ./webapps/rest/WEB-INF/lib/jersey-media-moxy-2.27.jar ./webapps/rest/WEB-INF/lib/jersey-entity-filtering-2.27.jar ./webapps/rest/WEB-INF/lib/jersey-media-jaxb-2.27.jar |

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ufal/clarin-dspace/issues/874?email_source=notifications&email_token=ABGOH6AEHUB7SZK5SBDKTTLQKSEFXA5CNFSM4FM2EQM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7GAQNY#issuecomment-533465143, or mute the thread https://github.com/notifications/unsubscribe-auth/ABGOH6DA7XTI7ORNF5BWW4DQKSEFXANCNFSM4FM2EQMQ.

done.

ilc4clarin running version 2019.01

./webapps/rest/WEB-INF/lib/jersey-client-2.27.jar ./webapps/rest/WEB-INF/lib/jersey-common-2.27.jar ./webapps/rest/WEB-INF/lib/jersey-container-servlet-2.27.jar ./webapps/rest/WEB-INF/lib/jersey-container-servlet-core-2.27.jar ./webapps/rest/WEB-INF/lib/jersey-entity-filtering-2.27.jar ./webapps/rest/WEB-INF/lib/jersey-hk2-2.27.jar ./webapps/rest/WEB-INF/lib/jersey-media-jaxb-2.27.jar ./webapps/rest/WEB-INF/lib/jersey-media-moxy-2.27.jar ./webapps/rest/WEB-INF/lib/jersey-server-2.27.jar

riccardo

kreetrapper commented 5 years ago
/opt/lindat-dspace/installation# find | grep "jersey"
./webapps/rest/WEB-INF/lib/jersey-container-servlet-core-2.27.jar
./webapps/rest/WEB-INF/lib/jersey-container-servlet-2.27.jar
./webapps/rest/WEB-INF/lib/jersey-common-2.27.jar
./webapps/rest/WEB-INF/lib/jersey-client-2.27.jar
./webapps/rest/WEB-INF/lib/jersey-media-moxy-2.27.jar
./webapps/rest/WEB-INF/lib/jersey-media-jaxb-2.27.jar
./webapps/rest/WEB-INF/lib/jersey-entity-filtering-2.27.jar
./webapps/rest/WEB-INF/lib/jersey-hk2-2.27.jar
./webapps/rest/WEB-INF/lib/jersey-server-2.27.jar
kosarko commented 5 years ago

@kreetrapper strange curl -H "Accept: application/json" https://clari/rest/handle/20.500.12124/6 now works for me, it didn't before, what changed?

the version box now works too

kreetrapper commented 5 years ago

@kosarko We just had a random restart of the box about an hour ago. Maybe that magically fixed things?

I can confirm that the version drop down now works in Firefox and Chromium. (Magic!)

iiegn commented 4 years ago

hm, this is no fun to debug... :( we do have occasional glitches within the kubernetes cluster that lead to communication interruptions between dspace and the database. but once communication is restored, dspace mostly seems to be doing ok. could this drop down (and the surrounding logic) be a case that does not self-heal after communication problems...? ...other ideas?

kosarko commented 4 years ago

@iiegn If you haven't already, try going through the dspace and tomcat logs from friday. Maybe there'll be some clue to why the json marshalling was not working.

iiegn commented 4 years ago

Our current hypothesis is that (within our kubernetes cluster) the OOM killer - or some k8s variant - might go around and, as a result, all sorts of strange things happen; we've seen other things that also made us wonder... We now try to cleanly restart services in such cases.

iiegn commented 2 years ago

With Firefox Version 102.0 (64-bit) on linux this problem does not occur anymore. (I haven't looked into this in a while but now seems to be 'Works-for-me')