Closed MikkCZ closed 7 years ago
@foxik r?
Thanks for the pull request. Currently I am ill, but I will try to get to it as soon as possible (I definitely want to test Firefox 52, I do not have newer versions on any of my compupters).
Merging. Thanks for your work.
The plugin seems to work on Firefox 52, but when loading it as a Temporary Add-on, the browser.runtime.onInstalled and browser.runtime.onStartup do not fire -- but when adding a direct call to the context menu creation, the plugins works. At this point I am assuming it is only a problem with the Temporary Add-on, but maybe I am doing the initialization wrong.
I will look at the initialization issue during the OpenAlt conference next week, where I will have a great opportunity during the WebExtensions API workshop. ;)
I have tested the extension in Firefox and it works. There are still few questions left:
There is some code that may be polished a bit for the current state of browsers API, but that I will cover later, as it's not in the scope of porting to Firefox 57.