Open Ansa211 opened 6 years ago
Hi, the "book" unicode character has been already replaced by a custom SVG icon in the "master" branch.
[x] if, by accident, the attribute expected by the token-detail plugin does not exist in the corpus, some error warning should be given (currently, when I accidentally named the attribute valframe
instead of pdtvallex
, the PDT-Vallex (disambiguated)
plugin always returned the first frame from the lexicon
[x] CzEngVallex plugin: when a single verb has two different pairs, the "show details" buttons should probably be Show details for pair 1
and Show details for pair 2
(currently, both buttons say Show details for pair 1
)
@Ansa211, I think this 'if, by accident, the attribute expected by the token-detail plugin does not exist in the corpus ..' is a matter of proper configuration since the attribute is assigned by a user in both places (token detail plugin config and corpus config). Therefore a user should know which attributes exist in a corpus and which of them he/she wants to use in the plugin.
- [ ] if, by accident, the attribute expected by the token-detail plugin does not exist in the corpus, some error warning should be given (currently, when I accidentally named the attribute
valframe
instead ofpdtvallex
, thePDT-Vallex (disambiguated)
plugin always returned the first frame from the lexicon
@tomachalek Is it possible to implement some sort of validation and warning in the current architecture?
Hi @Kira-D, please see https://github.com/czcorpus/kontext/pull/2591 and my Slack post.
@tomachalek Thanks! We'll update our master this week and test it.
Retesting after the recent update of production. These issues persist: Multiword KWIC issues:
New suggestions/comments:
second_verb=ALL
; maybe the dictionary title itself could be clickable?), or links to the pages limited to individual pairs, or even both.
I will list them here so that they are not forgotten.