Attention API should distinguish between keys and values

ufal / neuralmonkey

An open-source tool for sequence learning in NLP built on TensorFlow.

BSD 3-Clause "New" or "Revised" License

410 stars 102 forks source link

Attention API should distinguish between keys and values #533

Open jlibovicky opened 7 years ago

jlibovicky commented 7 years ago

In the upcoming API refactor (PR #509), we should distinguish between attention keys and values in the API, so they can be cached during ensembling independently on the particular attention model implementation.

jindrahelcl commented 7 years ago

This is more or less done..

jlibovicky commented 7 years ago

Is it? I wouldn't call it done before there will be abstract methods keys and values in the BaseAttention class.