ufal / neuralmonkey

An open-source tool for sequence learning in NLP built on TensorFlow.
BSD 3-Clause "New" or "Revised" License
410 stars 104 forks source link

default feed dict implementation moved to model part #718

Closed jindrahelcl closed 6 years ago

jindrahelcl commented 6 years ago

now, all model parts have self.train_mode and self.batch_size filled appropriately.

jindrahelcl commented 6 years ago

Odpadlo spoustu zbytečných řádek, pylintů disable, typových anotací v komentářích a importů

jindrahelcl commented 6 years ago

Od tý doby že kvůli nim vždycky musí být pylint disable no self use...

Dne st 20. 6. 2018 22:05 uživatel Jindřich Libovický < notifications@github.com> napsal:

@jlibovicky commented on this pull request.

Od kdy jsou placeholdery v init míto toho, aby byly @tensor?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ufal/neuralmonkey/pull/718#pullrequestreview-130567154, or mute the thread https://github.com/notifications/unsubscribe-auth/ABwcs6QIam17NZfPf8KXhYwMixJRS6vKks5t-qrsgaJpZM4Uve3W .