experiment.py crashes when git is not available

ufal / neuralmonkey

An open-source tool for sequence learning in NLP built on TensorFlow.

BSD 3-Clause "New" or "Revised" License

410 stars 104 forks source link

experiment.py crashes when git is not available #726

Closed Simon-Will closed 6 years ago

Simon-Will commented 6 years ago

In experiment.py there is a dependency on the command git being installed on the system. While saving the git commit and diff is certainly useful, git is not always available, especially on GPU computing servers.

I propose failing gracefully and just logging a warning that git is not available and git diff and git commit are not stored. I would be happy to do this and will send a pull request for this as well.

jindrahelcl commented 6 years ago

Good idea. Thanks.

varisd commented 6 years ago

Wasn't this resolved by #730 ?

jindrahelcl commented 6 years ago

Yes