search

ufal / npfl122

NPFL122 repository
Creative Commons Attribution Share Alike 4.0 International
13 stars 23 forks source link

REINFORCE with Baseline graph environment name #95

Closed gstaron closed 1 year ago

gstaron commented 1 year ago

Add environment name to graph on 13th slide of 6th lecture.

foxik commented 1 year ago

Thanks for the idea -- in the end I did not merge your image (it has 250k and the environment name can be just included in the slides as a text); instead, I added the image of the environment on the slide, and I also included the performance of the non-baseline REINFORCE, see https://ufal.mff.cuni.cz/~straka/courses/npfl122/2223/slides/?06#37.

But a community-work point is of course yours :+1:

gstaron commented 1 year ago

OK :) I would also recommend to add rows titles (1-step Q, n-step Q, A3C) to graphs tables at slides 27 and 28 (or even column names) as you've written there at lecture. It's not very visible (at least not for someone that can stop video-recording and read it I assume).

foxik commented 1 year ago

Yes, the legends on slides 27 and 28 are quite small, but I do not think it is a big problem (and I cannot easily align the text on the slides with the rows, because the whole figure is just one image); maybe the three legends (from the respective rows) could be extracted and a new figure with just the three legends could be created, and then placed on the left of the current figure -- but I currently do not plan to do it (but you are welcome to if you want :-).