search

ufal / treex

Treex NLP framework
33 stars 6 forks source link

Interset 2.049 fixes a bug in feature value for comparative #22

Closed dan-zeman closed 8 years ago

dan-zeman commented 8 years ago

Interset used "comp", Universal Features use "Cmp". New Interset uses "cmp" (capitalization is done automatically but the "o" caused the output to be incompatible. There might be other places in Treex, of which I am not aware and where this change must be reflected once the new Interset is installed.

martinpopel commented 8 years ago

Interset 2.049 is not backward compatible and it does not allow reading legacy treex files: it fails with "Unknown value 'comp' of feature 'degree'". So I suggest to wait with merging this PR until there is (new) Interset 2.050 which can handle both degree=comp and degree=cmp.

dan-zeman commented 8 years ago

https://github.com/dan-zeman/interset/commit/c1eec1ab75b0fc740e6ca3d721655a6fc60865ee