search

ufal / treex

Treex NLP framework
33 stars 6 forks source link

lxsuite_key is required #42

Open martinpopel opened 8 years ago

martinpopel commented 8 years ago 
perl -MTreex::Tool::LXSuite::LXConjugator -E '
my $conjugator = Treex::Tool::LXSuite::LXConjugator->new();'

produces an error Attribute (lxsuite_key) is required because the Client needs the key. Note that I have created ~/.lxsuite2 file. Also there should be a warning with an explanation message if this file is missing. The module above is needed by T2T::EN2PT::TurnVerbLemmaToAdjectives.

joaoantonioverdade commented 8 years ago

It was using the old LXSuite interface. It should be fixed now.

martinpopel commented 8 years ago

I still get the same error (with the newest master).

When closing a ticket it is a good custom to mention the commit/pull request which fixes the issue (or use https://help.github.com/articles/closing-issues-via-commit-messages/).

joaoantonioverdade commented 8 years ago

I am not following. Luis changed the interface, that way of calling the LXConjugator is no longer in use. I changed it in the TurnVerbLemmaToAdjectives, so where and why are you using the old interface? Did I miss any block?

martinpopel commented 8 years ago

perl -MTreex::Block::W2A::PT::TokenizeAndTag -E 'my $b=Treex::Block::W2A::PT::TokenizeAndTag->new();' results in error Attribute (lxsuite_key) is required at... The block W2A::PT::TokenizeAndTag is still in use in Scen::Analysis::PT, which is in use in pt2en translation.

If Treex::Tool::LXSuite::LXConjugator is no longer in use and it is not planned to be fixed, I would suggest to remove it (as well as Treex::Tool::LXSuite::LXConjugator which depends on it) from the master branch.