Version 5.0.0 not highlighting in iFrames in FF 67.0.4 (64-bit)

[aforsyth-nz]

worked fine before today's update.

I have attempted fault resolution by:- • checking/unchecking boxes in settings>misc; • uninstalling/reinstalling; • downgrading to version 4.1.1 (that works).

[ufb]

Version 5.0.0 not highlighting in iFrames

It was working for the iFrames i testest; can you please provide a URL? Then I can check if it's a bug.

downgrading to version 4.1.1 (that works)

Oh, downgrading browser extensions never is a good idea, because we cannot assure backwards compatibility. I'm surprised this is working for you ;) Please contact me in case you upgrade again to v5 and something is broken.

EDIT: Have you given Textmarker the following permission: Access browser activity during navigation ? v5 is asking for 2 new permissions, this is one of them and it's needed for loading Textmarker's content script programmatically into iFrames. This hasn't been necessary before, because I was using the content_scripts key in the manifest.json file for having scripts automatically injected into each website. With v5 the user can opt-out of automatic injections and do it manually.

[aforsyth-nz]

URL = http://customerzone.vodafone.co.nz/residential/inhome/tv/tvguide/tvg-grid.cfm Marking works in lower iFrame under v4.1.1 but has stopped functioning in v5.0.0~5.0.2 when page display has been set to display "My Channels"

Textmarker was allowed to set permissions when upgraded - not sure how/where to check that the permission: Access browser activity during navigation is set

[aforsyth-nz]

[ufb]

Ah, thanks a lot for these details! Just now I had a look into it and the problem seems the following: When you change some settings (i.e. switching to "My Channels" or submitting a different time frame) the inner frames are getting reloaded. Texmarker v5 is using programmatical script loading and is doing so by listening to URL changes of your tabs. But since the main URL of the current tab hasn't changed (only the ones of the inner frames), this script loading won't get triggered for the reloaded frames. I will try to fix it tomorrow. Thanks again for your help :)

[aforsyth-nz]

Many thanks @ufb, much appreciated. I was comparing the two manifest.json files & wasn't sure how to fix myself

[ufb]

Released 5.1.0 just now.

Permission Access browser activity during navigation is mandatory now. Plese report if you still have issues with non-loading scripts!

I experimented with above cited page: Should work in sub-frames now. But please not the following:

• Those pages seem to have frequently changing content, which will likely result in a restoration failure
• Depending on your settings and filters the URL might slightly change, so a page that looks exactly like the one you saved highlights on may acutally have a different URL - hence no highlights.

PS: Content scripts are not being loaded thru the content_scripts field in the manifest, but programmatically. The user can opt-out of automatic injections (Settings > Misc).

https://github.com/ufb/Textmarker/blob/master/src/background/modules/injection-manager.js

[aforsyth-nz]

That seems to be working now thanks