Closed 1-Bart-1 closed 4 weeks ago
Attention: Patch coverage is 17.64706%
with 28 lines
in your changes are missing coverage. Please review.
Project coverage is 66.60%. Comparing base (
4f1b5b4
) to head (172d521
). Report is 51 commits behind head on main.:exclamation: Current head 172d521 differs from pull request most recent head f2d282d
Please upload reports for the commit f2d282d to get more accurate results.
Files | Patch % | Lines |
---|---|---|
src/KiteModels.jl | 17.64% | 28 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Is there any practical application where the time of executing init_sim!()
limits the the overall performance?
Yes, when automatically optimizing the KCU or when optimizing other control methods, the kite has to be reset often. I am optimizing a neural network for the kite, and have to reset the kite at the start of every episode. It can also be useful when optimizing a PID controller using optimizing methods. So in any situation where the simulation has to be reset often.
On Sat, May 25, 2024, 17:16 Uwe Fechner @.***> wrote:
Is there any practical application where the time of executing init_sim!() limits the the overall performance?
— Reply to this email directly, view it on GitHub https://github.com/ufechner7/KiteModels.jl/pull/53#issuecomment-2131306409, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIBR55B6OM57SAZMBESQTDTZECTLTAVCNFSM6AAAAABIIY3OEOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZRGMYDMNBQHE . You are receiving this because you authored the thread.Message ID: @.***>
found a bug, reset wasnt working properly
One remark: For the four point model I suggest a stiffness-factor of 0.5. This save some time.
Each time the simulator is initialized with the same settings, the same integrator is found. This branch will load and save such pairs of integrators and abstract kite models, as this is way faster than calculating the integrator again and again.
When using integrator_history, KiteModels.init_sim! is 10x faster than whithout using integrator_history.