search

ufirstgroup / laravel-lang-import-export

A Laravel package providing artisan commands to import and export language files from and to CSV
MIT License
41 stars 40 forks source link

Laravel7 compatibility #5

Closed lenssoft closed 4 years ago

lenssoft commented 4 years ago

This PR adds compatibility to laravel ^7 (probably earlier versions too).

@mruoss could you make a new version tag (e.g. 7.0.0) out of this changes and possibly update the README about which versions to include based on laravel version.

mruoss commented 4 years ago

Hi @lenssoft

Unfortunately, I am not maintaining this module actively anymore. Would you be willing to take it over?

lenssoft commented 4 years ago

If i am going to use it in production then I will be able to take over. Until then I can use my forked repo with the compatibility fix.

mruoss commented 4 years ago

ok let me know.

lenssoft commented 4 years ago

Hi @mruoss We decided to use this package in production. Could you add me as a maintainer to the repo?

mruoss commented 4 years ago

Done. Let me know your packagist username if you want to deploy there.

lenssoft commented 4 years ago

My packagist username is lenssoft

mruoss commented 4 years ago

Also by the way, it seems like this project was forked and re-published already: https://github.com/highsolutions/laravel-lang-import-export

lenssoft commented 4 years ago

good to know

mruoss commented 4 years ago

Yeah, since I was not maintaining it, this makes sense. It is also has more downloads than my original one and is maintained. So feel free to re-create a pull request also on their side and maybe at some point we can close this project. Up to you.

mruoss commented 4 years ago

I guess you closed this in favor for https://github.com/highsolutions/laravel-lang-import-export/pull/10?

lenssoft commented 4 years ago

I closed this in favour of https://github.com/ufirstgroup/laravel-lang-import-export/pull/6

mruoss commented 4 years ago

I see. Thanks.