search

ufo-kit / ufo-filters

Common plugin suite for the ufo-core processing framework
GNU Lesser General Public License v3.0
10 stars 14 forks source link

Make phase retrieval directional #203

Closed tfarago closed 4 years ago

tfarago commented 4 years ago

i.e., separate x and y directions and let users specify effective propagation distance separately (z_x k_x^2 + z_y k_y^2).

tfarago commented 4 years ago

In order to keep #204 simple, I would do this with respect to pixel size rather than distance if you are OK with it @pretzsch

tfarago commented 4 years ago

@MathiasHurst just bringing you in here.

MathiasHurst commented 4 years ago

I think to specify the distance is much more intuitive for this use case. Maybe it would be easier to have separate filters for directional phase retrieval instead of enabling directional phase retrieval for all filters.

tfarago commented 4 years ago

Alright, after discussion with Rebecca we came to the same conclusion. However, I wouldn't make separate filters because that would clutter both ufo-filters and tofu. At least for now, let's see what I come up with in #204.

MathiasHurst commented 4 years ago

can you implement it in such a way, that if only one direction is specified the behaviour is the same as now? I think otherwise could be confusing, since the directional phase retrieval is a quit specific application.

tfarago commented 4 years ago

That's exactly how I did it.

pretzsch commented 4 years ago

Seems to work as expected, thanks!