search

ufo-kit / ufo-filters

Common plugin suite for the ufo-core processing framework
GNU Lesser General Public License v3.0
10 stars 14 forks source link

add stacked-backproject #214

Closed harishkumar-harihara closed 2 years ago

harishkumar-harihara commented 2 years ago

Reconstruct 2 or 4 slices in parallel

tfarago commented 2 years ago

Dear Harish, this already looks good! However, the (ufo-launch:17644): GLib-GObject-CRITICAL **: 10:35:11.525: validate_pspec_to_install: assertion 'G_IS_PARAM_SPEC (pspec)' failed is there because you declare 12 properties, but in ufo_stacked_backproject_task_class_init you only define 10. Also, could you please add the task and kernel files to meson (src/meson.build and src/kernels/meson.build)? And one last thing, please provide a description of what this is doing in the docs.

tfarago commented 2 years ago

I already have some fixes, if you give me push right to your repo we can fix the code together.

tfarago commented 2 years ago

Looks good. Could you include the normalization as well please? Also, you can squash everything into one commit so that we have a clean history in master. Thanks.

tfarago commented 2 years ago

Nice work!