search

ufodone / pyenvisalink

Envisalink 2DS/3 Alarm API for Honeywell or Ademco Vista Security Systems
MIT License
25 stars 19 forks source link

EnvisalinkAlarmPanel class overrides logging config #34

Open dhaustin opened 1 week ago

dhaustin commented 1 week ago

Thanks for all the hard work. Using this in a Samsung Smartthings environment and love it.

The EnvisalinkAlarmPanel class in alarm_panel.py currently overrides the logging configuration in the logging hierarchy when it is initialized. This results in log messages being sent to syslog rather than the log file defined in the users root logger. It also sets the logging level to DEBUG, which results in a lot of unnecessary logging if you are not in fact debugging. If this is somehow necessary, allow the user to reset the logging config on the instance.

ufodone commented 1 week ago

I inherited this code and so am not sure why it was setup like that but I can't think why this would be necessary so I should be able to change it.

Are you using the 4.x or 5.x version?

dhaustin commented 1 week ago

Using 4.6. Was unaware there is a 5.x version so will check into that.