search

ufosc / BytesOfLoveWebsite

A website for the OSC Visual Novel
8 stars 36 forks source link

Redesign Nabar #18

Closed WilsonGoins closed 1 month ago

WilsonGoins commented 4 months ago

The Navbar we currently have is functional, but the team agrees it is missing "something".

Redesign the Navbar component so that it still features the Open Source Club logo and clickable links to the 3 different pages.

This should be done by changing Navbar.js and Navbar.css.

xiaoguo-jia commented 4 months ago

can i have this issue? thank you!

WilsonGoins commented 4 months ago

can i have this issue? thank you!

Yes you can work on it, but someone already reached out to me and said they might be interested. Please collaborate with them. Their GitHub is: https://github.com/vyiirus11 Their discord is @dlenlen1228

xiaoguo-jia commented 4 months ago

ok thank you!

vyiirus11 commented 4 months ago

Yes, I was interested in doing this issue. My discord is @dlenlen1228 if you need to reach out about it.

xiaoguo-jia commented 3 months ago

@WilsonGoins What is the best way to get my changes approved to be pushed to the main branch? Would I be able to push my changes to the main branch, and then have @vyiirus11 add on top of it? I have contacted her on discord, and she agreed to this. Thank you!

WilsonGoins commented 3 months ago

@xiaoguo-jia @vyiirus11 I would say try to combine your changes together so that you guys can agree on one thing. Then make a PR that has your combined change. As far as making the PR we usually fork the repository and then compare the main branches so when you make your PR make it across repositories.

AntonCSalvador commented 3 months ago

@xiaoguo-jia @vyiirus11 I merged this but can you fix the navbar mobile view. When the user goes to mobile the navbar Screenshot at 2024-06-21 14-48-32 it looks a little scuffed with the bytes of love logo. Possible solutions are: