ufosc / BytesOfLoveWebsite

A website for the OSC Visual Novel
8 stars 36 forks source link

Music Player Button State Inconsistent When Switching Pages #42

Open AntonCSalvador opened 2 months ago

AntonCSalvador commented 2 months ago

Music Player Button State Inconsistent When Switching Pages

Description

On the BytesOfLove website, there is a music player button located at the bottom left of the screen. However, when switching between pages or tabs within the site, the state of the button (whether the music is playing or paused) does not persist. This requires users to manually re-click the button to continue or pause the music, which disrupts the user experience.

Steps to Reproduce

  1. Go to the BytesOfLove website.
  2. Click the music player button at the bottom left to start playing music.
  3. Navigate to a different page or switch tabs within the website.
  4. Observe that the music stops, and the button does not reflect the previous state (playing/paused).

Expected Behavior

Possible Solution

Additional Context

This issue affects the continuity of the user experience, especially for users who enjoy background music while browsing the website. It is also important to adhere to web laws.

StrBoll commented 1 month ago

Im on it!

AntonCSalvador commented 1 month ago

Thank you @StrBoll ! I will assign it right now

StrBoll commented 1 month ago

Committed the fixes but cant push to a new branch for the issue cause I don't have permissions.

edit -- nvm figured it out --

AntonCSalvador commented 1 month ago

@StrBoll Hey! great work! I tested in a bit and looks good. Can you open a pull request?

StrBoll commented 1 month ago

Pull request created.