search

ufosc / OSC-Proximity-Chat-App

Talk to the people closest to you. An open source React Native app that combines location and communication into one.
https://osc-proximity-documentation.vercel.app/
GNU General Public License v3.0
42 stars 94 forks source link

Add Prettier linting to project #253

Open h1divp opened 3 weeks ago

h1divp commented 3 weeks ago

Linting (which automatically formats saved files to have correct whitespacing, semicolons at the end of line, etc) is currently implemented in our Github actions pipline (automated testing system) but I think it would be beneficial to add Prettier support so that the linter runs after people save files in their IDE or text editor. Prettier is quite popular, and I also think we should recommend it in the documentation. That being said, even if we do add support, using prettier should still be completely optional, and just for those who would like to use it.

Note that this will need to be set up separately for both the front-end and back-end.

EdleyF commented 3 weeks ago

Can I tackle this issue?

h1divp commented 3 weeks ago

I left an important comment considering the Prettier implementation here I also didn't understand that Prettier isn't exactly a linter, but rather a code formatter, before creating this issue, my apologies.

AlexanderWangY commented 2 weeks ago

@h1divp any update on this? Should we close?

h1divp commented 2 weeks ago

Idk the person currently assigned hasn't responded to my last message, or otherwise I haven't heard from them

h1divp commented 2 weeks ago

I wouldn't close it but rather reassign if no progress is made soon