search

ufosc / OSC-Proximity-Chat-App

Talk to the people closest to you. An open source React Native app that combines location and communication into one.
https://osc-proximity-documentation.vercel.app/
GNU General Public License v3.0
43 stars 100 forks source link

Implimented prittier into the github action #256

Closed BaisonBeast closed 4 weeks ago

BaisonBeast commented 1 month ago

I have tried to implement pritter check into the GitHub actions. Fixes #253

h1divp commented 4 weeks ago

Maybe I didn't make it clear enough in my issue, but this isn't really meant to be change to our github actions, we already have ESLint to fix small really really minute bugs, though it still does need to be fixed.

Prettier is something that you can install as an extension into VS Code for instance, where it will automatically format whitespace (and similar things) every time you save the file you're currently working on. If many people were to use this, our codebase would become much more consistent stylistically.

That said, the issue I proposed would essentially be installing prettier as a development tool (npm i --save-dev) and creating the configuration file that would be laying in the project base directories for client and server. So when someone does install Prettier into their editor, the configuration it needs to be in line with the project is already there for them.

I will respecify this in my issue.

https://prettier.io/docs/en/comparison.html

h1divp commented 4 weeks ago

There are also a lot of configuration options. I would look up a default configuration that seems pretty standard for typescript, run it by a tech lead or leave a comment in the issue, and then move forward with approval.