search

ufosc / OSC-Proximity-Chat-App

Talk to the people closest to you. An open source React Native app that combines location and communication into one.
https://osc-proximity-documentation.vercel.app/
GNU General Public License v3.0
44 stars 101 forks source link

Have current-client user profile picture/display name be rendered in the chat screen #290

Open h1divp opened 1 month ago

h1divp commented 1 month ago

For #254. Note that this change only pertains to the currently logged in user and not for the messages received from other users.

Summary

Currently, the user is able to set their profile picture (a numbered image, and color hex code), and their display name (string) through the Settings Screen.

These are saved as state within the settings page. However, we need to make sure that these settings:

  1. Add and update their respecting parameters in the Settings Store so that they can be accessed anywhere in the app. The Store also keeps these parameters saved locally between logins.
  2. Actually render properly for any message that the logged in user sends, particularly in ChatMessage.tsx which state is passed to by the Message Channel (which is used in the Chat Screen).

After making these changes, create a PR and mention the Issue Number for this issue (so that it can close automatically after a merge). Comment below to be assigned.

Nqnt41 commented 1 month ago

I can give this a shot over the next few days, if thats alright.

Nqnt41 commented 1 month ago

Update: During CC yesterday I got a grasp on how to implement the first goal. Will mess with implementing the second goal over the weekend and hopefully try to finish it during CC Tuesday, depending on how things go over the weekend.

h1divp commented 1 month ago

Thank you for updating

Nqnt41 commented 4 weeks ago

Giving another update: still working on the issue, have just had a messy few weeks. Going to try to wrap it up soon if possible.

Nqnt41 commented 2 weeks ago

Sent out a Pull Request for this issue.