search

ufosc / manim-data-structures

A Manim plugin that contains common data structures to create Manimations.
https://manim-data-structures.readthedocs.io
MIT License
2 stars 26 forks source link

Remove useless inheritance from VGroup #3

Open Nikhil-42 opened 1 year ago

Nikhil-42 commented 1 year ago

Description

Several of the implemented Mobjects inherit from VGroup. This is typically unnecessary and can lead to strange behavior when using operators. Instead inherit from VMobject or Mobject.

Nikhil-42 commented 1 year ago

Make sure to verify that the functionality of the Mobject really doesn't depend on the VGroup inheritance. Namely, look at the methods and operators that VGroup adds (in vectorized_mobject.py) and see if they make sense to keep. For example, it doesn't really make sense that adding an Mobject to an MArrayElement links their positions, rotations, and scale together.