search

ufosc / manim-data-structures

A Manim plugin that contains common data structures to create Manimations.
https://manim-data-structures.readthedocs.io
MIT License
2 stars 26 forks source link

Prefer one public class per file over monolithic files #5

Open Nikhil-42 opened 1 year ago

Nikhil-42 commented 1 year ago

Description

The m_array.py module contains definitions and implementations for several related but public classes. This drastically reduces the readability of the file. There is general refactoring required here such as making MArrayElement an internal class, and splitting MArraySlidingWindow to a different file.

Nikhil-42 commented 1 year ago

Also, the file name should match the main class defined in that file. Ie "m_array.py" -> "marray.py" and "marrayslidingwindow.py"