Add xgboost in python - Githubissues

ufoym / deepo

Setup and customize deep learning environment in seconds.

http://ufoym.com/deepo

MIT License

6.32k stars 750 forks source link

Add xgboost in python #102

Closed aisensiy closed 5 years ago

aisensiy commented 5 years ago

xgboost is as common use as scikit-learn, so I add it into the python module.

aisensiy commented 5 years ago

Is this pr acceptable? Or what is your opinion for this?

ufoym commented 5 years ago

The following PRs are more preferable:

deep learning modules
tools on which those modules depend
tools on which building those modules depend

xgboost, of course, is excellent and commonly used in ML field. However, to keep deepo slim (we know, we know, deepo is actually too fat currently), we suggest installing xgboost on top of deepo image.

aisensiy commented 5 years ago

Yes, I understand your concern. Maybe make it as a separate module is better.

And actually, in my opinion, deepo is QUITE slim as a deep learning environment images. Look around for any other images with similar use cases (like floydhub/tensorflow). It is much bigger than deepo.