search

ufrisk / MemProcFS

MemProcFS
GNU Affero General Public License v3.0
2.81k stars 352 forks source link

[BUG] vmmsharp Vmm.MemReadArray #246

Closed imerzan closed 7 months ago

imerzan commented 7 months ago

https://github.com/ufrisk/MemProcFS/blob/646dd6e1b208f1106a5e2c696a61efde1085f55b/vmmsharp/vmmsharp.cs#L985C1-L985C1

The VMMDLL_MemReadEx parameters should be utilizing cb instead of count. This is only going to cause an issue with types that are greater than 1 byte in size, so probably why it wasn't noticed originally :D oops.

https://github.com/ufrisk/MemProcFS/blob/646dd6e1b208f1106a5e2c696a61efde1085f55b/vmmsharp/vmmsharp.cs#L990C29-L990C29

should also be cbRead != cb

ufrisk commented 7 months ago

Thanks. I'll fix this 👍

ufrisk commented 7 months ago

This should now be resolved. Huge thanks for making me aware of this :)