search

ufrisk / MemProcFS

MemProcFS
GNU Affero General Public License v3.0
3.14k stars 382 forks source link

`VmmProcess` should implement `Copy` #319

Closed zacryol closed 1 month ago

zacryol commented 1 month ago

https://github.com/ufrisk/MemProcFS/blob/98dd0d4933e1e149ba49ddc58af4202687d7a5fe/vmmrust/memprocfs/src/lib_memprocfs.rs#L1611-L1615

All of this struct's fields are pub and implement Copy, so there's no real reason to not make it Copy + Clone (or at the very least Clone).

The lack of these traits doesn't even prevent the user from "copying" it manually, since all fields are pub.

ufrisk commented 1 month ago

Thanks for the suggestion.

I've added Clone (and Copy to some degree) to a bunch of different structs in 5.11.7.

Let me know if this will do and if the changes are fine.

ufrisk commented 1 month ago

I'm closing this issue. Since I haven't heard anything about it, I'll assume things are fine.