search

ufront / ufront-mvc

The core MVC framework that powers ufront
MIT License
17 stars 15 forks source link

ViewResult - Local variable layoutReady used without being initialized #10

Closed mikedotalmond closed 9 years ago

mikedotalmond commented 9 years ago

I'm trying out Haxe 3.2 rc1 and get this error from ufront-mvc 1,0,0-rc,15 (haxelib)

Here's the line: https://github.com/ufront/ufront-mvc/blob/445e7741f6b5e67a11ffb8704ca9d08df90e1237/src/ufront/web/result/ViewResult.hx#L430

I'm currently 'fixing' / working around it by initialising layoutReady as null, here: https://github.com/ufront/ufront-mvc/blob/445e7741f6b5e67a11ffb8704ca9d08df90e1237/src/ufront/web/result/ViewResult.hx#L398

(though I don't know the codebase well enough to be sure it won't have side-effects... so reporting issue rather than creating a pr :)

Incidentally - thanks for ufront!

jasononeil commented 9 years ago

Thanks for reporting it!

I'll take a look and get 3.2 support working this week.

On Tue, Mar 17, 2015 at 8:00 AM, Mike Almond notifications@github.com wrote:

I'm trying out Haxe 3.2 rc1 and get this error from ufront-mvc 1,0,0-rc,15 (haxelib)

Here's the line:

https://github.com/ufront/ufront-mvc/blob/445e7741f6b5e67a11ffb8704ca9d08df90e1237/src/ufront/web/result/ViewResult.hx#L430

I'm currently 'fixing' / working around it by initialising layoutReady as null, here: https://github.com/ufront/ufront-mvc/blob/445e7741f6b5e67a11ffb8704ca9d08df90e1237/src/ufront/web/result/ViewResult.hx#L398

(though I don't know the codebase well enough to be sure it won't have side-effects... so reporting issue rather than creating a pr :)

Incidentally - thanks for ufront!

— Reply to this email directly or view it on GitHub https://github.com/ufront/ufront-mvc/issues/10.

mikedotalmond commented 9 years ago

Cheers. I'm not sure if it's a 3.2 thing, or a peculiarity with my set-up after updating to 3.2rc1 -- I'm also seeing what looks like a pretty odd variable initialisation issue on another (non-ufront) project I tried compiling lately.

jasononeil commented 9 years ago

Hi @mikedotalmond, fixed this one, still got a few more 3.2 related bugs to work through. I'll push a new version to haxelib once it's ready!