search

ufront / ufront-mvc

The core MVC framework that powers ufront
MIT License
17 stars 15 forks source link

FileSession: wrong php code being generated #28

Closed kevinresol closed 9 years ago

kevinresol commented 9 years ago

This line: https://github.com/ufront/ufront-mvc/blob/master/src/ufront/web/session/FileSession.hx#L225

in php is generated as: $tmp = null->asGoodSurprise(); which is a syntax error. (-> cannot be used on null)

kevinresol commented 9 years ago

Seems that it is a haxe issue. Track at https://github.com/HaxeFoundation/haxe/issues/4434 instead

kevinresol commented 9 years ago

Well since haxe doesn't want to fix that, ufront has to...

jasononeil commented 9 years ago

Thanks for picking that up. I understand Simon's reasoning... I just overlooked it when refactoring these recently. It'll be an easy fix, I'll try write some unit tests too.