fix binary response on nodejs

ufront / ufront-mvc

The core MVC framework that powers ufront

MIT License

17 stars 15 forks source link

fix binary response on nodejs #37

Closed kevinresol closed 8 years ago

kevinresol commented 8 years ago

a quick and dirty solution for #36

I still need to figure out if it is necessary to do the conversion var buffer = new js.node.Buffer([for(i in 0...bytes.length) bytes.get(i)]);

kevinresol commented 8 years ago

Because I am using js-kit and I have to disable hxnodejs due to some duplicated definitions of the externs. Hopefully js-kit will migrate to hxnodejs soon. cc @clemos

clemos commented 8 years ago

We're working on it :)

clemos commented 8 years ago

As for your issue, hxnodejs has some Bytes to Buffer conversion functions that I think may help: https://github.com/HaxeFoundation/hxnodejs/blob/master/src/js/node/buffer/Buffer.hx#L482-L492

kevinresol commented 8 years ago

thanks @clemos for pointing that conversion method! but at the moment I am still sticking with js-kit for Mongoose. I may come back to this later when js-kit fully migrated to hxnodejs.

kevinresol commented 8 years ago

@jasononeil please just keep this open for now

kevinresol commented 8 years ago

Closed this, see #42