search

ufront / ufront-mvc

The core MVC framework that powers ufront
MIT License
17 stars 15 forks source link

Fixed issue where php would SegFault with large multipart file uploads (20MB+) #67

Closed hexonaut closed 6 years ago

hexonaut commented 6 years ago

The code should be functionally equivalent because all sys platforms are synchronous. I'm not 100% sure what is causing the seg fault. I do know that the callbackFutures array is fairly large with a 20MB file. We are talking about 2500+ futures to be resolved.

Anyways, if the code functions the same and doesn't break on large files, I don't see why this shouldn't be merged - even if the root cause is unknown.

Haxe version is 3.4.7 PHP version on server is 5.6.31

kevinresol commented 6 years ago

For myself I am not using ufront anymore (and probably won't contribute anymore too). @jasononeil if it is the same case for you maybe at least we could invite into the team those who still want to contribute, so that they can merge the PRs?

hexonaut commented 6 years ago

@kevinresol I am working on an ongoing project using ufront, so I'm happy to help deal with managing the repos.