ValidationErrors map populated with duplicate values on validation

[milkmangames]

Have a subclass of ufront.db.Object with 4 fields.

Create a new instance and set each field to a value that will not validate (null):

var myObject=new MyObject();
myObject.field1=null;
myObject.field2=null;
myObject.field3=null;
myObject.field4=null;

object.validate();
trace(object.validationErrors);

Result: for each key, the validation error is repeated 4 times, i.e.:

[ field1: [ "field1 is a required field", "field1 is a required field", "field 1 is a required field", "field1 is a required field"] ] 

...and so on.

[milkmangames]

Whoops, this is not a problem with the lib.

Restarting haxe fixed the problem, and the number of repeated values grows with each compilation until its restarted again. So it appears to something with haxe macros and progressive compilation.

[jasononeil]

I think there are several issues with the compilation server at the moment. I'm re-opening this so I can try figure it out.

[milkmangames]

Cool thanks. See likely related posts here https://groups.google.com/forum/m/#!topic/haxelang/fCBCbUwTn5E

[jasononeil]

I've got some unit tests for validation now, I haven't run them with the compilation server, but they're passing when the compilation server is disabled. I'll try that next

[jasononeil]

Unit tests are still failing validation when using the compiler cache, but all other tests are passing. So other than getting multiple validation messages, the key functionality is actually working. I started trying to look into this, didn't make much progress today but will look again soon.

[jasononeil]

There is a workaround by @theRemix:

https://github.com/ufront/ufront-orm/commit/d60de85eb94bb515b53a90c07ce97e7079517cf1

I'm going to leave this issue open until I can fix it in DBMacros though, which would feel more correct.