search

ufront / ufront-orm

The Object Relational Mapper, allows easy, type-safe access to your database. Builds on Haxe's SPOD but adds macro powered relationships, validation and client side usage
MIT License
13 stars 4 forks source link

macro beaking completion #2

Closed postite closed 10 years ago

postite commented 10 years ago

i noticed this line prevent autocompletion in ST3 https://github.com/ufront/ufront-orm/blob/master/src/ufront/db/Object.hx#L48

i hacked it with

if !display

if !macro @:autoBuild(ufront.db.DBMacros.setupDBObject()) #end

end

don't know if it should be done via ST or in this code .. what do you think ?

jasononeil commented 10 years ago

Hmm, I used to get errors but I'm not anymore so I thought I had fixed it.

Does it provide any error message?

I could make the macro not run in display mode, but it is quite useful for showing the generated functions in autocomplete:

It's quite useful to have this stuff in autocomplete if possible, so I'd rather fix it than comment it out...

Also, which version of ufront-orm are you using, and which version of haxe (3.0.1, or git?)

Thanks for looking into it, hopefully have a fix soon.

Jason

On Tue, Jan 7, 2014 at 8:39 PM, postite notifications@github.com wrote:

i noticed this line prevent autocompletion in ST3

https://github.com/ufront/ufront-orm/blob/master/src/ufront/db/Object.hx#L48

i hacked it with

if !display

if !macro @:autoBuild(ufront.db.DBMacros.setupDBObject()) #end

end

don't know if it should be done via ST or in this code .. what do you think ?

— Reply to this email directly or view it on GitHubhttps://github.com/ufront/ufront-orm/issues/2 .

postite commented 10 years ago

hey jason ! i use git version of upfront-orm and haxe 3.01 as far as i remember i did have an error in the bottom of ST like "should be haxe.ds.Option" ...

cheers

jasononeil commented 10 years ago

That could be difficult to track, as I don't use haxe.ds.Option anywhere in the library :)

If you get a more complete error message please make sure to copy and paste it...

Cheers!

On Wed, Jan 8, 2014 at 5:13 PM, postite notifications@github.com wrote:

hey jason ! i use git version of upfront-orm and haxe 3.01 as far as i remember i did have an error in the bottom of ST like "should be haxe.ds.Option" ...

cheers

— Reply to this email directly or view it on GitHubhttps://github.com/ufront/ufront-orm/issues/2#issuecomment-31815544 .

jasononeil commented 10 years ago

I'm closing this for now. If you have a small example that demonstrates the problem I'll take another look.

Cheers!