search

ufs-community / UFS_UTILS

Utilities for the NCEP models.
Other
21 stars 104 forks source link

chgres_cube: Incorrect documentation in comments of program_setup.f90 #193

Closed LarissaReames-NOAA closed 1 year ago

LarissaReames-NOAA commented 3 years ago

Some of the new surface processing variables have incorrect default values listed in the comments at the top of program_setup.f90. The _from_climo variables should all have 'True' listed as their default setting.

GeorgeGayno-NOAA commented 3 years ago

Are these updates required for 'develop' and the release branch?

LarissaReames-NOAA commented 3 years ago

If we want the in-line documentation to be correct, yes.

GeorgeGayno-NOAA commented 3 years ago

Do you want make the same update to the SRW release branch under this issue?

LarissaReames-NOAA commented 3 years ago

Ah yes, I blanked for a minute. I'll push that here soon.

edwardhartnett commented 3 years ago

Any progress on this? We are starting to write unit tests for the chgres_cube code. Any documentation updates would be most welcome, otherwise there will be confusion when tests are written.

edwardhartnett commented 3 years ago

Any progress here? We are fixing all chgres_cube doxygen documentation last week and this week, so this is a good time for documentation updates. Soon we will be writing tests for these codes...

edwardhartnett commented 3 years ago

Can this issue be closed?

edwardhartnett commented 3 years ago

@GeorgeGayno-NOAA do you know if this issue is still active?

@LarissaReames-NOAA are you getting notifications when someone posts a question in one of your GitHub issues?

GeorgeGayno-NOAA commented 3 years ago

I don't know if the issue is active. The changes were merged to 'develop'. But I don't know if they were pushed to the SRW App release.

LarissaReames-NOAA commented 3 years ago

This will be pushed to release/public-v2 in the first bug fix release.

GeorgeGayno-NOAA commented 2 years ago

@LarissaReames-NOAA Can this issue be closed?