ufs-community / UFS_UTILS

Utilities for the NCEP models.
Other
21 stars 105 forks source link

chgres_cube, release/public-v2: Soil type issue at land ice vegetation points #246

Closed LarissaReames-NOAA closed 3 years ago

LarissaReames-NOAA commented 3 years ago

Due to inconsistencies in landmask between HRRR and FV3, and how HRRR data handles vegetation and soil type at frozen lakes / land ice points, some points exist in surface output data with soil type of 0 at land ice points.

The fix for this, while not ideal, is a brute force method of forcing all grid points with land use type of land ice to have soil type 16 in the qc_check subroutine. I have been unsuccessful, despite many many efforts, to implement a fix by modifying the input data just after reading in, or by making changes in the interp subroutine. Will use this brute force fix for now, but will contact ESMF support before implementing a fix in the develop branch.

GeorgeGayno-NOAA commented 3 years ago

Do you know why the problem (soil type 0) only happens at land ice points?

lharris4 commented 3 years ago

Hello. I don't understand how this is a problem with FV3. FV3 is a dynamical core and has no conception of vegetation type, lakes, or land ice.

On Mon, Jan 25, 2021 at 1:58 PM GeorgeGayno-NOAA notifications@github.com wrote:

Do you know why the problem (soil type 0) only happens at land ice points?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/UFS_UTILS/issues/246#issuecomment-767038873, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMUQRVFAXBTSNFO47V76NA3S3W5NRANCNFSM4WSDLVRQ .

LarissaReames-NOAA commented 3 years ago

Do you know why the problem (soil type 0) only happens at land ice points?

It's honestly a complete mystery. I've tracked the total number of problem points on the target grid (by checking places where soil type is 0 over land points) and they are remedied by doing a soil type interpolation along with the other land ice to land ice interpolation calls, but then they reappear (the exact same number) after the land, non-land ice interpolation. I confirmed that there are no soil type of 0 at any land points on the input grid, so I'm honestly not sure where those points are originating from.

LarissaReames-NOAA commented 3 years ago

Hello. I don't understand how this is a problem with FV3. FV3 is a dynamical core and has no conception of vegetation type, lakes, or land ice.

Lucas, this is the UFS_UTILS GitHub, not FV3.

Unless you're referring to the line where I mention inconsistencies in landmask, in which case I'm referring to the only landmask that we've been provided. I guess that wouldn't actually be FV3 then, it would just be the assumed landmask on the target grid.

Edit: Lucas, my apologies. I don't know why I said Larry.

lharris4 commented 3 years ago

I am referring to this line in the original message.

Due to inconsistencies in landmask between HRRR and FV3, and how HRRR data handles vegetation and soil type at frozen lakes / land ice points, some points exist in surface output data with soil type of 0 at land ice points.

On Mon, Jan 25, 2021 at 3:46 PM Larissa Reames notifications@github.com wrote:

Hello. I don't understand how this is a problem with FV3. FV3 is a dynamical core and has no conception of vegetation type, lakes, or land ice. … <#m-4298420939195509969>

Larry, this is the UFS_UTILS GitHub, not FV3.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/UFS_UTILS/issues/246#issuecomment-767101854, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMUQRVF2L6PBGERFPFPQMP3S3XKBDANCNFSM4WSDLVRQ .

LarissaReames-NOAA commented 3 years ago

I am referring to this line in the original message. Due to inconsistencies in landmask between HRRR and FV3, and how HRRR data handles vegetation and soil type at frozen lakes / land ice points, some points exist in surface output data with soil type of 0 at land ice points.

Yeah, I realized that after I read your message again and my original post. My apologies. Please see the edit in my reply comment where I clarified that statement.

lharris4 commented 3 years ago

Thanks :-)

GeorgeGayno-NOAA commented 3 years ago

Do you know why the problem (soil type 0) only happens at land ice points?

It's honestly a complete mystery. I've tracked the total number of problem points on the target grid (by checking places where soil type is 0 over land points) and they are remedied by doing a soil type interpolation along with the other land ice to land ice interpolation calls, but then they reappear (the exact same number) after the land, non-land ice interpolation. I confirmed that there are no soil type of 0 at any land points on the input grid, so I'm honestly not sure where those points are originating from.

Do you want me to take a quick look at your branch?

LarissaReames-NOAA commented 3 years ago

Do you know why the problem (soil type 0) only happens at land ice points?

It's honestly a complete mystery. I've tracked the total number of problem points on the target grid (by checking places where soil type is 0 over land points) and they are remedied by doing a soil type interpolation along with the other land ice to land ice interpolation calls, but then they reappear (the exact same number) after the land, non-land ice interpolation. I confirmed that there are no soil type of 0 at any land points on the input grid, so I'm honestly not sure where those points are originating from.

Do you want me to take a quick look at your branch?

Sure, you're welcome to do that. More eyes on the problem can never hurt. The branch that I've applied the suggested fix to, but haven't attached to a PR, is feature/chgres_cube_landice_fix.

GeorgeGayno-NOAA commented 3 years ago

How do you set "soiltyp_from_climo" (and the other 'from_climo' settings)?

LarissaReames-NOAA commented 3 years ago

How do you set "soiltyp_from_climo" (and the other 'from_climo' settings)?

They're set in the namelist. And to run in to these problems, they should be set to false. This tells the code to interpolate these surface arrays to the target grid and use them instead of the data from the sfc_climo files.

LarissaReames-NOAA commented 3 years ago

Fix merged, regression tests updated and passing on all systems. Issue closed.