Bad snow values from CHGRES_CUBE

ufs-community / UFS_UTILS

Utilities for the NCEP models.

Other

21 stars 104 forks source link

Bad snow values from CHGRES_CUBE #27

Closed GeorgeGayno-NOAA closed 4 years ago

GeorgeGayno-NOAA commented 4 years ago

Julie Schramm reported a problem with the snow field for a regional grid. The odd snow values were occurring at open water points. I was able to reproduce the problem using the head of 'develop' (4643e2c). I also noticed bad ice depth values at land points.

I ran a quick test that zeroes out these surface fields after the call to FieldCreate. That appears to have fixed it. To be safe, I will initialize all surface fields after FieldCreate to a proper value.

GeorgeGayno-NOAA commented 4 years ago

Julie tested the fix on her test case and verified that it is working. I ran the chgres_cube regression tests on Jet, Hera, Cray and Dell. Remarkably, all tests passed. Apparently, this bug only shows its ugly face under very specific configurations. I did not investigate further. Will initiate a pull request to 'develop'.

GeorgeGayno-NOAA commented 4 years ago

Work on this issue is complete. Closing.