search

ufs-community / ccpp-physics

UFS fork for CCPP
Other
4 stars 33 forks source link

If input_lakedepth is lost between restarts, CLM Lake model will crash #146

Closed SamuelTrahanNOAA closed 9 months ago

SamuelTrahanNOAA commented 9 months ago

Description

If CLM Lake is used in FV3 as intended, input_lakedepth should never be 0. The world is not always ideal. Sometimes there may be a change in orography between cycles of a cycled model. Or, something may go wrong in the model restart procedure. This can lead to input_lakedepth=0 on some points.

When that happens, there is a divide by zero in the clm lake mode.

Steps to Reproduce

  1. Fill input_lakedepth with 0 in a restart file.
  2. Restart the model.
  3. Witness the divide by zero error.

Additional Context

This was discovered during RRFS parallels.